Page MenuHomePhorge
Files F2571750

No OneTemporary
Actions

Size
30 KB
Referenced Files
None
Subscribers
None

View Options

diff --git a/.github/run.sh b/.github/run.sh
index ab67e274c..36070b8ae 100755
--- a/.github/run.sh
+++ b/.github/run.sh
@@ -1,38 +1,38 @@
#!/bin/bash
# The script is intended for use on Travis with Trusty distribution
# It installs in-browser tests dependencies and prepares Roundcube instance
GMV=1.5.11
CHROMEVERSION=$(google-chrome-stable --version | tr -cd [:digit:]. | cut -d . -f 1)
GMARGS="-Dgreenmail.setup.all -Dgreenmail.users=test:test -Dgreenmail.startup.timeout=3000"
# Make temp and logs writeable
sudo chmod 777 temp logs
# Install javascript dependencies
bin/install-jsdeps.sh
# Compile Elastic's styles
lessc --clean-css="--s1 --advanced" skins/elastic/styles/styles.less > skins/elastic/styles/styles.min.css
lessc --clean-css="--s1 --advanced" skins/elastic/styles/print.less > skins/elastic/styles/print.min.css
lessc --clean-css="--s1 --advanced" skins/elastic/styles/embed.less > skins/elastic/styles/embed.min.css
# Use minified javascript files
bin/jsshrink.sh
# Install proper WebDriver version for installed Chrome browser
php tests/Browser/install.php $CHROMEVERSION
# GreenMail server download, setup and start
wget https://repo1.maven.org/maven2/com/icegreen/greenmail-standalone/$GMV/greenmail-standalone-$GMV.jar \
&& (sudo java $GMARGS -jar greenmail-standalone-$GMV.jar &) \
&& sleep 5
# Run tests
-echo "TESTS_MODE: DESKTOP" \
-&& TESTS_MODE=desktop vendor/bin/phpunit -c tests/Browser/phpunit.xml \
+echo "\nTESTS_MODE: DESKTOP" \
+&& TESTS_MODE=desktop vendor/bin/phpunit -c tests/Browser/phpunit.xml --exclude-group=failsonga \
&& echo "TESTS_MODE: PHONE" \
-&& TESTS_MODE=phone vendor/bin/phpunit -c tests/Browser/phpunit.xml \
+&& TESTS_MODE=phone vendor/bin/phpunit -c tests/Browser/phpunit.xml --exclude-group=failsonga-phone \
&& echo "TESTS_MODE: TABLET" \
-&& TESTS_MODE=tablet vendor/bin/phpunit -c tests/Browser/phpunit.xml
+&& TESTS_MODE=tablet vendor/bin/phpunit -c tests/Browser/phpunit.xml --exclude-group=failsonga-tablet
diff --git a/tests/Browser/Settings/FoldersTest.php b/tests/Browser/Settings/FoldersTest.php
index 16627f299..ab238e2fd 100644
--- a/tests/Browser/Settings/FoldersTest.php
+++ b/tests/Browser/Settings/FoldersTest.php
@@ -1,153 +1,154 @@
<?php
namespace Tests\Browser\Settings;
use Tests\Browser\Components\App;
class FoldersTest extends \Tests\Browser\TestCase
{
public static function setUpBeforeClass()
{
\bootstrap::init_imap();
\bootstrap::reset_mailboxes();
}
/**
* Test Folders UI
*/
public function testFolders()
{
$this->browse(function ($browser) {
$browser->go('settings', 'folders');
// task should be set to 'settings' and action to 'folders'
$browser->with(new App(), function ($browser) {
$browser->assertEnv('task', 'settings');
$browser->assertEnv('action', 'folders');
// these objects should be there always
$browser->assertObjects(['quotadisplay', 'subscriptionlist']);
});
if ($browser->isDesktop()) {
$browser->assertVisible('#settings-menu li.folders.selected');
}
if ($browser->isPhone()) {
$browser->assertVisible('.floating-action-buttons a.create:not(.disabled)');
}
else {
$browser->assertMissing('.floating-action-buttons a.create:not(.disabled)');
}
// Toolbar menu
$browser->assertToolbarMenu(['create'], ['delete', 'purge']);
// Folders list
$browser->with('#subscription-table', function ($browser) {
// Note: first li element is root which is hidden in Elastic
$browser->assertHasClass('li:nth-child(2)', 'inbox')
->assertSeeIn('li:nth-child(2)', 'Inbox')
->assertPresent('li:nth-child(2) [type=checkbox][disabled]')
->assertHasClass('li:nth-child(3)', 'drafts')
->assertSeeIn('li:nth-child(3)', 'Drafts')
->assertPresent('li:nth-child(3) [type=checkbox][disabled]')
->assertHasClass('li:nth-child(4)', 'sent')
->assertSeeIn('li:nth-child(4)', 'Sent')
->assertPresent('li:nth-child(4) [type=checkbox][disabled]')
->assertHasClass('li:nth-child(5)', 'junk')
->assertSeeIn('li:nth-child(5)', 'Junk')
->assertPresent('li:nth-child(5) [type=checkbox][disabled]')
->assertHasClass('li:nth-child(6)', 'trash')
->assertSeeIn('li:nth-child(6)', 'Trash')
->assertPresent('li:nth-child(6) [type=checkbox][disabled]');
});
});
}
/**
* Test folder creation
*
* @group failsontravis-phone
+ * @group failsonga-phone
*/
public function testFolderCreate()
{
$this->browse(function ($browser) {
$browser->go('settings', 'folders');
$num = count($browser->elements('#subscription-table li'));
if ($browser->isPhone()) {
$browser->assertVisible('.floating-action-buttons a.create:not(.disabled)')
->click('.floating-action-buttons a.create')
->waitFor('#preferences-frame');
}
else {
$browser->clickToolbarMenuItem('create');
}
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->waitFor('form')
->with('form fieldset', function ($browser) {
$browser->assertVisible('input[name=_name]')
->assertValue('input[name=_name]', '')
->assertVisible('select[name=_parent]')
->assertSelected('select[name=_parent]', '');
})
/*
->with('form fieldset:last-child', function ($browser) {
$browser->assertSeeIn('legend', 'Settings')
->assertVisible('select[name=_viewmode]')
->assertSelected('select[name=_viewmode]', '0');
})
*/
->type('input[name=_name]', 'Test');
if (!$browser->isPhone()) {
$browser->click('.formbuttons button.submit');
}
});
if ($browser->isPhone()) {
$browser->assertVisible('#layout-content .header a.back-list-button')
->assertVisible('#layout-content .footer .buttons a.button.submit')
->click('#layout-content .footer .buttons a.button.submit')
->waitFor('#subscription-table');
}
else {
$browser->waitForMessage('confirmation', 'Folder created successfully.');
}
$browser->closeMessage('confirmation');
$num++;
// Folders list
$browser->with('#subscription-table', function ($browser) use ($num) {
// Note: li.root is hidden in Elastic
$browser->waitFor("li.mailbox:nth-child({$num})")
->assertElementsCount('li', $num - 1)
->assertPresent("li.mailbox:nth-child({$num}) [type=checkbox]:not([disabled])")
->click("li.mailbox:nth-child({$num})");
});
if ($browser->isPhone()) {
$browser->waitFor('#preferences-frame');
}
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->waitFor('form');
// TODO
});
// Test unsubscribe of the newly created folder
if ($browser->isPhone()) {
$browser->click('a.back-list-button')
->waitFor('#subscription-table');
}
$browser->setCheckboxState("#subscription-table li:nth-child({$num}) input", false)
->waitForMessage('confirmation', 'Folder successfully unsubscribed.');
});
}
}
diff --git a/tests/Browser/Settings/IdentitiesTest.php b/tests/Browser/Settings/IdentitiesTest.php
index 8d759e8d8..0ebd3f79c 100644
--- a/tests/Browser/Settings/IdentitiesTest.php
+++ b/tests/Browser/Settings/IdentitiesTest.php
@@ -1,268 +1,272 @@
<?php
namespace Tests\Browser\Settings;
use Tests\Browser\Components\App;
use Tests\Browser\Components\Dialog;
use Tests\Browser\Components\Popupmenu;
class IdentitiesTest extends \Tests\Browser\TestCase
{
public static function setUpBeforeClass()
{
\bootstrap::init_db();
}
public function testIdentities()
{
$this->browse(function ($browser) {
$browser->go('settings', 'identities');
// check task and action
$browser->with(new App(), function ($browser) {
$browser->assertEnv('task', 'settings');
$browser->assertEnv('action', 'identities');
// these objects should be there always
$browser->assertObjects(['identitieslist']);
});
if ($browser->isDesktop()) {
$browser->assertVisible('#settings-menu li.identities.selected');
}
// Identities list
$browser->assertVisible('#identities-table tr:first-child.focused');
$browser->assertSeeIn('#identities-table tr:first-child td.mail', TESTS_USER);
// Toolbar menu
$browser->assertToolbarMenu(['create'], ['delete']);
});
}
/**
* Test identity creation
*
* @group failsontravis-phone
+ * @group failsonga-phone
*/
public function testIdentityCreate()
{
$this->browse(function ($browser) {
$browser->go('settings', 'identities');
if ($browser->isPhone()) {
$browser->assertVisible('.floating-action-buttons a.create:not(.disabled)')
->click('.floating-action-buttons a.create')
->waitFor('#preferences-frame');
}
else {
$browser->clickToolbarMenuItem('create');
}
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->waitFor('form')
->with('form fieldset:nth-of-type(1)', function ($browser) {
$browser->assertSeeIn('legend', 'Settings')
->assertVisible('input[name=_name]')
->assertValue('input[name=_name]', '')
->assertSeeIn('label[for=rcmfd_name]', 'Display Name')
->assertVisible('input[name=_email]')
->assertValue('input[name=_email]', '')
->assertSeeIn('label[for=rcmfd_email]', 'Email')
->assertVisible('input[name=_organization]')
->assertValue('input[name=_organization]', '')
->assertSeeIn('label[for=rcmfd_organization]', 'Organization')
->assertVisible('input[name=_reply-to]')
->assertValue('input[name=_reply-to]', '')
->assertSeeIn('label[for=rcmfd_reply-to]', 'Reply-To')
->assertVisible('input[name=_bcc]')
->assertValue('input[name=_bcc]', '')
->assertSeeIn('label[for=rcmfd_bcc]', 'Bcc')
->assertCheckboxState('input[name=_standard]', false)
->assertSeeIn('label[for=rcmfd_standard]', 'Set default');
})
->with('form fieldset:nth-of-type(2)', function ($browser) {
$browser->assertSeeIn('legend', 'Signature')
->assertVisible('textarea[name=_signature]')
->assertValue('textarea[name=_signature]', '');
})
->type('_name', 'My Test')
->type('_email', 'mynew@identity.com')
->type('_organization', 'My Organization')
->type('_reply-to', 'replyto@domain.tld')
->type('_bcc', 'bcc@domain.tld')
->setCheckboxState('input[name=_standard]', true)
->type('_signature', 'My signature');
if (!$browser->isPhone()) {
$browser->click('.formbuttons button.submit');
}
});
if ($browser->isPhone()) {
$browser->assertVisible('#layout-content .header a.back-list-button')
->whenAvailable('#layout-content .footer .buttons', function ($browser) {
$browser->click('a.button.submit');
});
}
$browser->waitForMessage('confirmation', 'Successfully saved.')
->closeMessage('confirmation')
->waitFor('#preferences-frame');
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->whenAvailable('form', function ($browser) {
$browser->assertValue('input[name=_name]', 'My Test')
->assertValue('input[name=_email]', 'mynew@identity.com')
->assertValue('input[name=_organization]', 'My Organization')
->assertValue('input[name=_reply-to]', 'replyto@domain.tld')
->assertValue('input[name=_bcc]', 'bcc@domain.tld')
->assertValue('textarea[name=_signature]', 'My signature')
->assertCheckboxState('input[name=_standard]', true);
});
});
// Toolbar menu (Delete button is active now)
$browser->assertToolbarMenu(['create', 'delete']);
if ($browser->isPhone()) {
$browser->click('#layout-content .header a.back-list-button')
->waitFor('#identities-table');
}
// Identities list
$browser->with('#identities-table', function ($browser) {
$browser->assertElementsCount('tbody tr', 2)
->assertSeeIn('tbody tr:nth-child(2)', 'My Test');
});
});
}
/**
* Test identity deletion
*
* @depends testIdentityCreate
* @group failsontravis-phone
+ * @group failsonga-phone
*/
public function testIdentityDelete()
{
$this->browse(function ($browser) {
$browser->click('#identities-table tbody tr:first-child')
->waitFor('#preferences-frame')
->clickToolbarMenuItem('delete');
$browser->with(new Dialog(), function ($browser) {
$browser->assertDialogTitle('Are you sure...')
->assertDialogContent('Do you really want to delete this identity?')
->assertButton('mainaction.delete', 'Delete')
->assertButton('cancel', 'Cancel')
->clickButton('mainaction.delete');
});
$browser->waitForMessage('confirmation', 'Successfully deleted.')
->closeMessage('confirmation');
// Preview frame should reset to the watermark page
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->waitUntilMissing('> div');
});
$browser->waitFor('#layout-list')
->assertElementsCount('#identities-table tbody tr', 1);
// Toolbar menu (Delete button is inactive again)
$browser->assertToolbarMenu(['create'], ['delete']);
});
}
/**
* Test identity update
*
* @depends testIdentityDelete
* @group failsontravis-phone
+ * @group failsonga-phone
*/
public function testIdentityUpdate()
{
$this->browse(function ($browser) {
$browser->click('#identities-table tbody tr:last-child')
->waitFor('#preferences-frame')
->waitUntilMissing('#messagestack div.loading');
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->whenAvailable('form', function ($browser) {
$browser->type('[name=_name]', 'Default')
->type('[name=_organization]', 'Default Org');
});
if (!$browser->isPhone()) {
$browser->click('.formbuttons button.submit');
}
});
if ($browser->isPhone()) {
$browser->whenAvailable('#layout-content .footer', function ($browser) {
$browser->assertVisible('a.button.prev.disabled')
->assertVisible('a.button.next.disabled')
->click('a.button.submit');
});
}
$browser->waitForMessage('confirmation', 'Successfully saved.')
->closeMessage('confirmation')
->waitFor('#preferences-frame');
if ($browser->isPhone()) {
$browser->click('#layout-content .header a.back-list-button');
}
$browser->whenAvailable('#identities-table', function ($browser) {
$browser->assertSeeIn('tbody tr:last-child', 'Default <mynew@identity.com>');
});
});
}
/**
* Test identities in mail composer
*
* @depends testIdentityUpdate
* @group failsontravis-phone
+ * @group failsonga-phone
*/
public function testIdentitiesInComposer()
{
// Add one more identity
(new \rcube_user(1))->insert_identity([
'email' => 'another@domain.tld',
]);
$this->browse(function ($browser) {
if ($browser->isPhone()) {
$browser->click('a.back-sidebar-button');
}
// Goto Compose and test the identity selector
$browser->clickTaskMenuItem('compose')
->waitFor('#compose-content')
->assertElementsCount('select[name=_from] > option', 2)
->assertSeeIn('select[name=_from] > option[selected]', 'mynew@identity.com');
$this->assertTrue(trim($browser->value('#_bcc'), ', ') === 'bcc@domain.tld');
$this->assertTrue(trim($browser->value('#_replyto'), ', ') === 'replyto@domain.tld');
$this->assertTrue(strpos($browser->value('#composebody'), 'My signature') !== false);
// TODO: Recipient input, HTML mode, identity change
// Test "unsaved changes" dialog
$browser->type('#compose-subject', 'subject')
->click('#compose_from a.edit')
->with(new Dialog(), function ($browser) {
$browser->assertDialogTitle('Are you sure...')
->assertDialogContent('The message has not been sent and has unsaved changes. Do you want to discard your changes?')
->assertButton('mainaction.discard', 'Discard')
->assertButton('cancel', 'Cancel')
->clickButton('discard');
});
$browser->waitFor('#identities-table');
});
}
}
diff --git a/tests/Browser/Settings/ResponsesTest.php b/tests/Browser/Settings/ResponsesTest.php
index fb45a36ac..e42de79e0 100644
--- a/tests/Browser/Settings/ResponsesTest.php
+++ b/tests/Browser/Settings/ResponsesTest.php
@@ -1,269 +1,273 @@
<?php
namespace Tests\Browser\Settings;
use Tests\Browser\Components\App;
use Tests\Browser\Components\Dialog;
use Tests\Browser\Components\Popupmenu;
class ResponsesTest extends \Tests\Browser\TestCase
{
public static function setUpBeforeClass()
{
\bootstrap::init_db();
}
public function testResponses()
{
$this->browse(function ($browser) {
$browser->go('settings', 'responses');
$browser->with(new App(), function ($browser) {
// check task and action
$browser->assertEnv('task', 'settings');
$browser->assertEnv('action', 'responses');
// these objects should be there always
$browser->assertObjects(['responseslist']);
});
if ($browser->isDesktop()) {
$browser->assertVisible('#settings-menu li.responses.selected');
}
// Responses list
$browser->assertPresent('#responses-table')
->assertMissing('#responses-table tr');
// Toolbar menu
$browser->assertToolbarMenu(['create'], ['delete']);
});
}
/**
* Test response creation
*
* @group failsontravis-phone
+ * @group failsonga-phone
*/
public function testResponseCreate()
{
$this->browse(function ($browser) {
$browser->go('settings', 'responses');
if ($browser->isPhone()) {
$browser->assertVisible('.floating-action-buttons a.create:not(.disabled)')
->click('.floating-action-buttons a.create')
->waitFor('#preferences-frame');
}
else {
$browser->clickToolbarMenuItem('create');
}
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->waitFor('form')
->with('form', function ($browser) {
$browser->assertVisible('input[name=_name]')
->assertValue('input[name=_name]', '')
->assertSeeIn('label[for=ffname]', 'Name')
->assertVisible('textarea[name=_text]')
->assertValue('textarea[name=_text]', '')
->assertSeeIn('label[for=fftext]', 'Response Text');
})
->type('_name', 'Test')
->type('_text', 'Response Body');
if (!$browser->isPhone()) {
$browser->click('.formbuttons button.submit');
}
});
if ($browser->isPhone()) {
$browser->assertVisible('#layout-content .header a.back-list-button')
->waitFor('#layout-content .footer .buttons')
->click('#layout-content .footer .buttons a.button.submit');
}
$browser->waitForMessage('confirmation', 'Successfully saved.')
->closeMessage('confirmation')
->waitFor('#preferences-frame');
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->waitFor('form')
->with('form', function ($browser) {
$browser->assertVisible('input[name=_name]')
->assertValue('input[name=_name]', 'Test')
->assertValue('textarea[name=_text]', 'Response Body');
});
});
if ($browser->isPhone()) {
$browser->click('#layout-content .header a.back-list-button')
->waitFor('#responses-table');
}
// Responses list
$browser->with('#responses-table', function ($browser) {
$browser->assertElementsCount('tbody tr', 1)
->assertSeeIn('tbody tr:nth-child(1)', 'Test');
});
if ($browser->isPhone()) {
$browser->click('#responses-table tbody tr:first-child')
->waitFor('#preferences-frame');
}
// Toolbar menu (Delete button is active now)
$browser->assertToolbarMenu(['create', 'delete']);
});
}
/**
* Test response deletion
*
* @depends testResponseCreate
* @group failsontravis-phone
+ * @group failsonga-phone
*/
public function testResponseDelete()
{
$this->browse(function ($browser) {
$browser->clickToolbarMenuItem('delete');
$browser->with(new Dialog(), function ($browser) {
$browser->assertDialogTitle('Are you sure...')
->assertDialogContent('Do you really want to delete this response text?')
->assertButton('mainaction.delete', 'Delete')
->assertButton('cancel', 'Cancel')
->clickButton('mainaction.delete');
});
$browser->waitForMessage('confirmation', 'Successfully deleted.')
->closeMessage('confirmation');
// Preview frame should reset to the watermark page
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->waitUntilMissing('> div');
});
$browser->waitFor('#layout-list')
->assertElementsCount('#responses-table tbody tr', 0);
// Toolbar menu (Delete button is inactive again)
$browser->assertToolbarMenu(['create'], ['delete']);
});
}
/**
* Test responses in mail composer
*
* @depends testResponseDelete
* @group failsontravis-phone
+ * @group failsonga-phone
*/
public function testResponsesInComposer()
{
// Quickly create a set of responses
$responses = [
['name' => 'Test 1', 'text' => 'Response 1', 'format' => 'text', 'key' => substr(md5('Test 1'), 0, 16)],
['name' => 'Test 2', 'text' => 'Response 2', 'format' => 'text', 'key' => substr(md5('Test 2'), 0, 16)],
];
(new \rcube_user(1))->save_prefs(['compose_responses' => $responses]);
$this->browse(function ($browser) {
if ($browser->isPhone()) {
$browser->click('a.back-sidebar-button');
}
// Goto Compose and test the responses menu
$browser->clickTaskMenuItem('compose')
->waitFor('#compose-content')
->clickToolbarMenuItem('responses')
->with(new Popupmenu('responses-menu'), function ($browser) {
$browser->assertMenuState(['create.responses', 'edit.responses'])
->with('#responseslist', function ($browser) {
$browser->assertElementsCount('li', 2)
->assertSeeIn('li:nth-child(1) a.insertresponse', 'Test 1')
->assertSeeIn('li:nth-child(2) a.insertresponse', 'Test 2');
})
->closeMenu();
});
// Insert a response to the message body
$browser->type('#composebody', 'Body and ')
->clickToolbarMenuItem('responses')
->waitFor('#responseslist')
->click('#responseslist li:nth-child(1) a.insertresponse')
->waitUntilMissing('#responses-menu');
$browser->waitUntilMissing('.popover-overlay')
->assertValue('#composebody', 'Body and Response 1')
->waitForMessage('confirmation', 'Response inserted successfully.')
->closeMessage('confirmation');
// TODO: Test HTML mode, test response creation
});
}
/**
* Test response update
*
* @depends testResponsesInComposer
* @group failsontravis-phone
+ * @group failsonga-phone
*/
public function testResponseUpdate()
{
$this->browse(function ($browser) {
// We're in mail compose, use responses menu to goto Settings > Responses
$browser->clickToolbarMenuItem('responses')
->waitFor('#responses-menu')
->click('#responses-menu a.edit.responses')
->with(new Dialog(), function ($browser) {
$browser->assertDialogTitle('Are you sure...')
->assertDialogContent('The message has not been sent and has unsaved changes. Do you want to discard your changes?')
->assertButton('mainaction.discard', 'Discard')
->assertButton('cancel', 'Cancel')
->clickButton('discard');
});
$browser->waitFor('#responses-table')
->assertSeeIn('#responses-table tbody tr:first-child td', 'Test 1')
->click('#responses-table tbody tr:first-child')
->waitFor('#preferences-frame');
$browser->withinFrame('#preferences-frame', function($browser) {
$browser->waitFor('form')
->with('form', function ($browser) {
$browser->assertValue('[name=_name]', 'Test 1')
->assertValue('[name=_text]', 'Response 1')
->type('[name=_name]', 'Test 11')
->type('[name=_text]', 'Response 11');
});
if (!$browser->isPhone()) {
$browser->click('.formbuttons button.submit');
}
});
if ($browser->isPhone()) {
$browser->waitFor('#layout-content .footer')
->with('#layout-content .footer', function ($browser) {
$browser->assertVisible('a.button.prev.disabled')
->assertVisible('a.button.next:not(.disabled)')
->click('a.button.submit');
});
}
$browser->waitForMessage('confirmation', 'Successfully saved.')
->closeMessage('confirmation');
if ($browser->isPhone()) {
$browser->click('#layout-content .header a.back-list-button')
->waitFor('#responses-table');
}
// Responses list
$browser->with('#responses-table', function ($browser) {
$browser->assertSeeIn('tbody tr:nth-child(1)', 'Test 11');
});
});
}
}

File Metadata

Mime Type
text/x-diff
Expires
Thu, Mar 19, 8:57 AM (1 d, 2 h)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
457681
Default Alt Text
(30 KB)

Event Timeline